Re: [PATCH 3/4] Support working directory located at root
- From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
- Date
- Feb 11, 2010, 12:44 UTC
- Message-ID
- <fcaeb9bf1002110444v4ada90f5t8fd7d9163956c9f3@mail.gmail.com>
- In-Reply-To
- <201002092019.45134.j6t@kdbg.org>
On 2/10/10, Johannes Sixt <j6t@kdbg.org> wrote:
Show 8 quoted lines
> On Dienstag, 9. Februar 2010, Nguyễn Thái Ngọc Duy wrote: > > I said I would have code change for DOS drive too. But I take it back. > > Supporting GIT_DIR=C:\.git might be easy, GIT_DIR=C:.git is not. > > > One does not set GIT_DIR=C:.git; it would be insane because it means ".git in > an unpredictable directory somewhere on drive C". It would be great to > support GIT_DIR=C:/.git
A bit off topic, but make_relative_path() may need more care for the Windows port. I thought of making relative path between C:/foo and D:/bar but it should work well for that case. //machine/share1/foo and //machine/share2/bar may fail though.
-- Duy