Re: hitting home directory's parent

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Aug 23, 2009, 04:07 UTC
Message-ID: <fcaeb9bf0908222107i6d999335r998a304aaa3cd405@mail.gmail.com>
In-Reply-To: <20090822181607.GA25823@coredump.intra.peff.net>

On Sun, Aug 23, 2009 at 1:16 AM, Jeff King<peff@peff.net> wrote:

Show 21 quoted lines

> On Sat, Aug 22, 2009 at 11:20:39PM +0700, Nguyen Thai Ngoc Duy wrote:
>
>> > I did read a bit farther in the manual and initialized a new repository.
>> > Issuing "git --help" once inside that new repository works.  Requiring
>> > the --help command to be called from inside a repository, or even that
>> > it's looking for a repository at all, seems unwise.  All it should do is
>> > display the usage information and exit.
>>
>> For simple things like --help, I agree Git should not do extra work
>> such as searching for Git repository, which is the cause. That was on
>> Jeff's plan IIRC.
>
> Without looking, I would not be surprised if it is a side effect of
> git trying to look up help-related config. So I don't think it is a
> problem exactly that it checks to see if it is in a repo (which would
> impact config lookup), but that inability to find a repo is a hard
> error.
>
> Probably it is calling "setup_git_directory_gently" and ignoring an
> error return, but there is a die() inside that function. The bug
> then is that the _gently form is calling die().

It is (and should be worked around with GIT_CEILING_DIRECTORIES). Unfortunately in my test, it could not chdir() back when it failed to find gitdir. chdir() was called with an absolute directory, and one directory in that path was inaccesible, leading another die("Cannot come back to cwd"). This one is fatal and should not be ignored. I don't know whether having an inaccesible parent directory is a real scenario, as lots of tools would break.

-- 
Duy