Re: [PATCH] format-patch: add --prefix to prepend a prefix to output file names

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Jun 9, 2009, 23:14 UTC
Message-ID: <fcaeb9bf0906091614y7392bfa8p20a4e5c3c37a051b@mail.gmail.com>
In-Reply-To: <4A2E576D.704@op5.se>

2009/6/9 Andreas Ericsson <ae@op5.se>:

Show 22 quoted lines

> Nguyễn Thái Ngọc Duy wrote:
>>
>> I use git to manages patches in my Gentoo development. In Gentoo,
>> all ebuilds (another form of RPM spec) corresponding to different
>> versions of the same package are grouped into one directory. So patches
>> for each versions usually have a prefix to separate them from the ones
>> for other versions. With --prefix it comes handy to produce such patches,
>> for example:
>>
>> git format-patch --prefix dbus-1.2.3- HEAD~5
>>
>> will generate patches for dbus-1.2.3 for me, all starting with
>> "dbus-1.2.3-".
>>
>> This might be handy for RPM developers as well.
>>
>
> I'm thinking this could be confused with '--subject-prefix' which was
> given the long option to *not* confuse it with cover-letters and filename
> prefixes. Any chance you could make it --filename-prefix instead? Since
> it already lacks a short option, the extra typing will probably be worth
> it to avoid unnecessary confusion.

I made it --prefix because I see --suffix for file names already. Yes --filename-prefix may be less confusing than plain --prefix.

-- 
Duy