Re: [PATCH 5/9] update-index: add --checkout/--no-checkout to update CE_NO_CHECKOUT bit
- From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
- Date
- Nov 20, 2008, 15:26 UTC
- Message-ID
- <fcaeb9bf0811200726x1f2956c6k6f2ca16543a0fbc@mail.gmail.com>
- In-Reply-To
- <20081119130223.GA27893@segfault.peff.net>
On 11/19/08, Jeff King <peff@peff.net> wrote:
Show 23 quoted lines
> On Tue, Nov 18, 2008 at 06:18:10PM -0800, Junio C Hamano wrote: > > > Having said all that, I wouldn't suggest redoing the patch using >> > > redirection. But change from "touch 1 nondigit" to "touch nondigit 1" > > is a bit too subtle to my taste. Let's write it this way instead: > > > Yes, I also dislike the subtlety, but my "obvious" idea was something > like: > > for i in 1 2 sub/1 sub/2; do > touch $i > done > > which just seemed clunky. But: > > > > - touch 1 2 sub/1 sub/2 && > > + touch ./1 ./2 sub/1 sub/2 && > > > this is less clunky, and I have confirmed that it solves the problem. I > just wasn't clever enough to think of it in the first place. ;)
Thanks for catching. The last half also has the same problem. Another way is maybe just stay away for those numbers, naming the files by alphabet. Just wonder if we could have some ways to automatically catch this kind of bug in the future.
-- Duy