Re: [PATCH 1/2] diffcore-rename: support rename cache

> On Sat, Nov 08, 2008 at 11:01:20AM +0700, Nguyen Thai Ngoc Duy wrote:
>  > On 11/8/08, Junio C Hamano <gitster@pobox.com> wrote:
>  > > Yann Dirson <ydirson@altern.org> writes:
>  > >
>  > >  > On Fri, Nov 07, 2008 at 09:35:32PM +0700, Nguy???n Thái Ng???c Duy wrote:
>  > >  >> This patch teaches diffcore_rename() to look into
>  > >  >> $GIT_DIR/rename-cache and make use of it to recreate diff_filepair.
>  > >  >> With proper cache, there should be no available entry for estimation
>  > >  >> after exact matching.
>  > >  >
>  > >  > This is something I have thought about in the past, good to see that
>  > >  > implemented :)
>  > >  >
>  > >  >> Rename caching is per commit. I don't think abitrary tree-tree caching
>  > >  >> is worth it.
>  > >  >
>  > >  > That could be a nice complement to my directory-rename patch.
>  > >
>  > >
>  > > Has anybody thought about interaction between that caching and pathspec
>  > >  limited operation?
>  > >
>  >
>  > I didn't. But I think all out-of-pathspec diff pairs are removed
>  > before it reaches diffcore_rename() so the cache has nothing to do
>  > with it (except it still loads full cache for a commit).
>
>
> Well, it could be that an out-of-pathspec pair would have a better
>  score than an in-pathspec one.  Maybe cache recording should be turned
>  off when doing pathspec limitation ?