Re: [PATCH] Extend index to save more flags

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Sep 2, 2008, 07:33 UTC
Message-ID: <fcaeb9bf0809020033i6ed8c268gac3cedcbebe57e26@mail.gmail.com>
In-Reply-To: <7vhc8zm2ka.fsf@gitster.siamese.dyndns.org>

On 9/2/08, Junio C Hamano <gitster@pobox.com> wrote:

Show 15 quoted lines

> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>
>  > The on-disk format of index only saves 16 bit flags, nearly all have
>  > been used. The last bit (CE_EXTENDED) is used to for future extension.
>  >
>  > This patch extends index entry format to save more flags in future.
>  > The new entry format will be used when CE_EXTENDED bit is 1.
>  >
>  > Because older implementation may not understand CE_EXTENDED bit and
>  > misread the new format, if there is any extended entry in index, index
>  > header version will turn 3, which makes it incompatible for older git.
>  > If there is none, header version will return to 2 again.
>
>
> I think this is a good change.

Just don't apply it now. There is a bug in die() code for unknown flags. I'll resend with narrow checkout series, which will also be a test case for these change.

-- 
Duy