Re: [PATCH 02/12] git-grep: support --no-external-grep

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Jul 24, 2008, 23:16 UTC
Message-ID: <fcaeb9bf0807241616k787ea8cco75d1a93a3eb516@mail.gmail.com>
In-Reply-To: <20080724202634.GB3760@blimp.local>

On 7/25/08, Alex Riesen <raa.lkml@gmail.com> wrote:

Show 9 quoted lines

> Nguyen Thai Ngoc Duy, Wed, Jul 23, 2008 16:55:49 +0200:
>
> >
>  > +static int no_external_grep;
>  > +
>
>
> If you have used direct logic instead of negative, your patch would
>  have been simplier and the code would be easier to understand. I.e.:

Point taken.

Show 6 quoted lines

>  +               if (!strcmp("--no-external-grep", arg)) {
>  +                       external_grep = 0;
>  +                       continue;
>  +               }
>
>  BTW, how about a config option for this? And maybe --external-grep={yes|no}

I don't need --external-grep=yes now, but that would be good for testing external grep. About config option, is it really needed?

-- 
Duy