Re: setup_git_directory_gently contract question?

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: May 27, 2008, 15:32 UTC
Message-ID: <fcaeb9bf0805270832lc779a37gd9e58d0790981788@mail.gmail.com>
In-Reply-To: <8e04b5820805270710v3a06e5c2if2dcf3b94ef40c1f@mail.gmail.com>

On Tue, May 27, 2008 at 9:10 PM, Ciprian Dorin Craciun <ciprian.craciun@gmail.com> wrote:

>    Is the function setup_git_directory_gently supposed to change the
> current working directory, or should it keep the initial one?

It will change if it finds a worktree.

>    What is the meaning of nongit_ok?

Setting it to a non null pointer prevents git from die() when no git repository can be found.

>    Because if I use nongit_ok != NULL, but *nongit_ok == 1, this
> function changes the current working directory to the top of the
> worktree directory.

It returns a directory prefix so that you can still know the original current working directory. You can do as following to have current directory "unchanged"

prefix = setup_git_directory_gently(&nongit_ok); if (prefix) chdir(prefix)

Show 7 quoted lines

>    Thanks,
>    Ciprian Craciun.
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

-- 
Duy