git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 6/9] Completely move out worktree setup from setup_git_directory_gently()

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
Feb 28, 2008, 12:52 UTC
Message-ID
<fcaeb9bf0802280452h1180c4f2gdc92874a3627d0c5@mail.gmail.com>
In-Reply-To
<alpine.LSU.1.00.0802281124420.22527@racer.site>

On Thu, Feb 28, 2008 at 6:26 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 10 quoted lines
> Hi,
>
>
>  On Wed, 27 Feb 2008, Nguyễn Thái Ngọc Duy wrote:
>
>  > This was impossible earlier because git_dir can be relative. Now that
>  > git_dir is absolute, I see no reason for worktree setup inside
>  > setup_git_directory_gently().
>
>  I do see it, though.  Why make the users work harder?

To make clear separation of worktree usage? I think it's good to add setup_work_tree() where you really need it. Right now in commands that use setup_git_directory_gently(), it is (to me) really hard to tell whether an option require worktree.

Another point of removing worktree setup from _gently(): worktree setup can die() while _gently()'s purpose is, well, do it gently. If it's not safe, let the caller decide.

Also having to deal with prefix while you don't need worktree at all is a bit of work that can be eliminated with this series.

>  If you want to get
>  the git directory, chances are that you want to work with a worktree, too.
Yes. That's why I keep worktree setup in setup_git_directory().
>  And you really cannot properly separate worktree detection from git
>  directory detection: in most of the cases, you will find them at the
>  _same_ time (if .git/ is the git directory, the working directory is .).

No I don't separate worktree detection. I only avoid moving to worktree unless necessary. Right after _gently() you can tell if you have a worktree and where it is.

Show 5 quoted lines
>  So I am mildly negative on the thrust of your patch series.
>
>  Ciao,
>  Dscho
>
-- 
Duy
Previous: Johannes SchindelinNext: Nguyễn Thái Ngọc Duy
Message 19 of 24 in “"git read-tree -m" and the like require worktree”
  1. 1/9 "git read-tree -m" and the like require worktreeNguyễn Thái Ngọc Duy, Feb 27, 2008
  2. Junio C HamanoFeb 28, 2008
  3. Nguyen Thai Ngoc DuyFeb 28, 2008
  4. 2/9 Make sure setup_git_directory is called before accessing repositoryNguyễn Thái Ngọc Duy, Feb 27, 2008
  5. 3/9 Make get_git_dir() and 'git rev-parse --git-dir' absolute pathNguyễn Thái Ngọc Duy, Feb 27, 2008
  6. 4/9 Make setup_work_tree() return new prefixNguyễn Thái Ngọc Duy, Feb 27, 2008
  7. Johannes SchindelinFeb 28, 2008
  8. Nguyen Thai Ngoc DuyFeb 28, 2008
  9. Johannes SchindelinFeb 28, 2008
  10. 5/9 http-push: Avoid calling setup_git_directory() twiceNguyễn Thái Ngọc Duy, Feb 27, 2008
  11. Junio C HamanoFeb 28, 2008
  12. Nguyen Thai Ngoc DuyFeb 28, 2008
  13. 6/9 Completely move out worktree setup from setup_git_directory_gently()Nguyễn Thái Ngọc Duy, Feb 27, 2008
  14. Junio C HamanoFeb 28, 2008
  15. Nguyen Thai Ngoc DuyFeb 28, 2008
  16. Junio C HamanoFeb 28, 2008
  17. Nguyen Thai Ngoc DuyFeb 28, 2008
  18. Johannes SchindelinFeb 28, 2008
  19. Nguyen Thai Ngoc DuyFeb 28, 2008
  20. 7/9 builtin-archive: mark unused prefix "unused_prefix"Nguyễn Thái Ngọc Duy, Feb 27, 2008
  21. 8/9 Make setup_git_directory() auto-setup worktree if foundNguyễn Thái Ngọc Duy, Feb 27, 2008
  22. 9/9 Documentation: update api-builtin and api-setupNguyễn Thái Ngọc Duy, Feb 27, 2008
  23. Jonathan NiederApr 5, 2011
  24. Nguyen Thai Ngoc DuyApr 5, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.