Re: [PATCH 1/2] Show html help with git-help --html

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Jun 5, 2007, 19:42 UTC
Message-ID: <fcaeb9bf0706051242o7ded089dwabd281226befe63d@mail.gmail.com>
In-Reply-To: <20070605193451.GG17377@planck.djpig.de>

On 6/5/07, Frank Lichtenheld <frank@lichtenheld.de> wrote:

Show 10 quoted lines

> On Tue, Jun 05, 2007 at 06:34:20PM +0000, Nguyen Thai Ngoc Duy wrote:
> > +core.help::
> > +     If 'html', it is equivalent to 'git-help' with option --html.
> > +     If 'auto', it tries to open html files first. If that attempt fails
> > +     (the html program does not exist or the program return non-zero
> > +     value), then it will fall back to man pages. If 'man', always use
> > +     man pages as usual.
>
> This should mention the default value. (Which is 'man', if I read the
> code correctly, isn't it?)

Ok.

Show 13 quoted lines

>
> > +core.htmlprogram::
> > +     Specify the program used to open html help files when 'git-help'
> > +     is called with option --html or core.help is other than 'man'.
> > +     By default, xdg-open will be used.
> > +     Special strings '%p', '%f' and '%b' will be replaced with html
> > +     full path, file name and git command (without .html suffix)
> > +     respectively. If none is given, '%p' will be automatically appended
> > +     to the command line.
>
> htmlprogram sounds kludgy to me. I would've used htmlcommand or perhaps
> htmlviewer. But I'm no native English speaker, so I might be entirely
> wrong about that.

Will vote for any better name than htmlprogram as I see it awkward too :) htmlviewer seems better (or htmlviewercommand, which is too long). Anyway I'm not a native English speaker either.

Show 6 quoted lines

>
> Gruesse,
> --
> Frank Lichtenheld <frank@lichtenheld.de>
> www: http://www.djpig.de/
>

-- 
Duy