Re: [PATCH] Don't segfault if the given SHA1 name is longer than 40 characters

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Oct 19, 2006, 04:54 UTC
Message-ID: <fcaeb9bf0610182154l55de75d1w4a99db608f7f6477@mail.gmail.com>
In-Reply-To: <7vwt6xvt7q.fsf@assigned-by-dhcp.cox.net>

On 10/19/06, Junio C Hamano <junkio@cox.net> wrote:

> The patch is correct, but it needs a better explanation in the
> proposed commit log message than just "Don't segfault".

Well, maybe because I got a segfault when I accidentally pasted an sha1 twice (blame my mouse). I hadn't looked closely enough to the bug. Anyway, you got the bug and obviously have a better explanation than mine. Please fix it with a better explanation. I'll be more explanatory next time. Thank you :-)

Show 8 quoted lines

> get_describe_name() can be fed a string foo-gXXX...XXX with a
> very looooooooong hexstring.  It calls get_short_sha1() without
> checking if XXX...XXX part is longer than 40-bytes (in which
> case it cannot be a valid object name).
>
> get_sha1_1() has the same problem.  Given a hexstring longer
> than 40-bytes, it calls the function with it because earlier
> ones such as get_sha1_hex() would reject the input.

-- 
Duy