[PATCH v2 2/2] unpack-trees: use repository from index instead of global

From: Jayesh Daga via GitGitGadget <gitgitgadget@gmail.com>
Date: Mar 31, 2026, 15:34 UTC
Message-ID: <fbdf3271b7b05d9e3afc9aa3d476ccd64f867d08.1774971267.git.gitgitgadget@gmail.com>
In-Reply-To: <pull.2258.v2.git.git.1774971267.gitgitgadget@gmail.com>

From: Jayesh Daga <jayeshdaga99@gmail.com>

unpack_trees() currently initializes its repository from the global 'the_repository', even though a repository instance is already available via the source index.

Use 'o->src_index->repo' instead of the global variable, reducing reliance on global repository state.

This is a step towards eliminating global repository usage in unpack_trees().

Suggested-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Jayesh Daga <jayeshdaga99@gmail.com>
---
 unpack-trees.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/unpack-trees.c b/unpack-trees.c
index 191b9d4769..b42020f16b 100644
--- a/unpack-trees.c
+++ b/unpack-trees.c
@@ -1882,7 +1882,7 @@ static int verify_absent(const struct cache_entry *,
  */
 int unpack_trees(unsigned len, struct tree_desc *t, struct unpack_trees_options *o)
 {
-	struct repository *repo = the_repository;
+	struct repository *repo = o->src_index->repo;
 	int i, ret;
 	static struct cache_entry *dfc;
 	struct pattern_list pl;

-- 
gitgitgadget