Re: [BUG] rebase: can write reflog with uninit. `action` string

From: Kristoffer Haugsbakk <code@khaugsbakk.name>
Date: Apr 29, 2025, 19:40 UTC
Message-ID: <fbc97d6a-2022-4a64-a2ba-5a7255cd81a6@app.fastmail.com>
In-Reply-To: <ce0f41e4-7d90-4398-a0e9-e8ba69791e57@gmail.com>

Hi Phillip

On Tue, Apr 29, 2025, at 11:22, Phillip Wood wrote:

Show 5 quoted lines

>> #0  run_git_commit (defmsg=0x555555babe70 "<repo path>/MERGE_MSG", opts=0x7fffffffc070, flags=0) at sequencer.c:1158
>
> Thanks for the backtrace. It would be useful to know what's stored in
> opts->ctx->reflog_message at this point if it's not too much trouble
> please can you run "print *opts" and "print *opts->ctx" here.

Today I ran on f65182a99e5 (The ninth batch, 2025-04-24) at sequencer.c:1148. I was never able to reproduce this `opts->ctx->reflog_message` having a weird value with GDB today. The reflog was also fine.

Then I ran without GDB and I got the weird reflog that I expected.

So I don’t know what `*opts` or `*opts->ctx` looks like here. But I did find just two minutes ago some old notes about `ctx->reflog_message`:

``` Thread 1 "git" hit Breakpoint 1, run_git_commit (defmsg=0x555555babe70 "<merge msg path>", opts=0x7fffffffc070, flags=0) at sequencer.c:1158 1158 strvec_pushf(&cmd.env, GIT_REFLOG_ACTION "=%s", ctx->reflog_message); @(gdb) p ctx->reflog_message $23 = 0x555555ba0d50 "\250y\267UUU" @(gdb) ```

It’s line 1158 because of my debug code apparently.