git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-svn: make git svn --version work again

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
Mar 4, 2010, 10:23 UTC
Message-ID
<fb196463677f8560aa490eaa137990ab2d5d6b86.1267698128.git.git@drmicha.warpmail.net>
by requesting SVN::Core which is needed for the svn version.
Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
---
In fact, there are a few more places where seemingly a req_svn() is missing.
But the call chains are very confusing. The one seemingly missing in prop_walk()
would be covered by the recursive props test which succeeds, so the caller
must have requested SVN::Core also. I believe this applies to the other places
as well (but not to version()).

Is there any harm done by inserting a superfluous req_svn() in these cases for good measure?

 git-svn.perl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index bae7231..1ffb44c 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -351,6 +351,7 @@ information.
 }
 
 sub version {
+	::_req_svn();
 	print "git-svn version $VERSION (svn $SVN::Core::VERSION)\n";
 	exit 0;
 }
-- 
1.7.0.1.300.gd855a
Next: Eric Wong
Message 1 of 2 in “git-svn: make git svn --version work again”
  1. git-svn: make git svn --version work againMichael J Gruber, Mar 4, 2010
  2. Eric WongMar 5, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.