Re: gitweb-projects

From: Jakub Narebski <jnareb@gmail.com>
Date: Aug 24, 2007, 00:08 UTC
Message-ID: <fal7gn$2vf$1@sea.gmane.org>
In-Reply-To: <9e4733910708231438q4c454686p55cef622e61d6a2a@mail.gmail.com>

[Cc: Jon Smirl <jonsmirl@gmail.com>, git@vger.kernel.org]

Jon Smirl wrote:

> What is the magic incantation for encoding an email address along with
> the project owner name? From the source I see these strings need to be
> URL encoded (it doesn't seem to be in the doc)

It is mentioned in gitweb/INSTALL, in the "Gitweb repositories" section

> but now I'm getting XML errors.
>
> I tried this:
> mpc5200b.git Jon+Smirl+%3Cjonsmirl%2664%3Bgmail.com%3E

I guess that this might have nothing to do with URL-encoding of projects index file, but with proper escaping in the gitweb, i.e. the string is not wrapped in esc_html.

In other words, it is a bug in the gitweb.

Show 5 quoted lines

> Does this string really need to be URL encoded? Couldn't you split on
> the first space and then url encode it in the perl code? That would
> let me write the string in English instead of geek.
> 
> mpc5200b.git Jon Smirl <jonsmirl@gmail.com>

Not possible, as path to repository can contain spaces.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git