Re: [PATCH] Improve documentation for git-remote-helpers
- From
Sverre Rabbelier <srabbelier@gmail.com>
- Date
- Mar 22, 2010, 15:40 UTC
- Message-ID
- <fabb9a1e1003220840q5b9b791ft83c8fd4793b83be2@mail.gmail.com>
- In-Reply-To
- <alpine.LNX.2.00.1003211951360.14365@iabervon.org>
Heya,
On Mon, Mar 22, 2010 at 01:06, Daniel Barkalow <barkalow@iabervon.org> wrote:
Show 5 quoted lines
> Looks generally right, but I think you need to do > "finish_command(&exporter);" first, and actually get some feedback from > the helper. I think the right thing is actually to put the output of the > helper into fast-import again, and have that give one of three > conclusions:
I'm not sure that makes sense (at least to me). I think you are right in that we need to collect output from the helper, but I don't see any added value in feeding that into fast-import. I think we should rather read from the helper after we finish exporting to figure out what happened. The different cases you described are I think indeed what we should look for.
-- Cheers, Sverre Rabbelier