Re: [PATCH 2/2] clone: pass the remote name to remote_get
- From
Sverre Rabbelier <srabbelier@gmail.com>
- Date
- Mar 21, 2010, 23:27 UTC
- Message-ID
- <fabb9a1e1003211627q7ea75194j941fe9ae23f77b66@mail.gmail.com>
- In-Reply-To
- <1269202789-8833-2-git-send-email-srabbelier@gmail.com>
Heya,
On Sun, Mar 21, 2010 at 21:19, Sverre Rabbelier <srabbelier@gmail.com> wrote:
Show 7 quoted lines
> Currently when using a remote helper to clone a repository, the > remote helper will be passed the url of the target repository as > first argument (which represents the name of the remote). This name > is extracted from transport->remote->name, which is set by > builtin/clone.c when it calls remote_get with argv[0] as argument. > > Fix this by passing the name remote will be set up as instead.
Ah, I forgot a sign-off it seems. Also, these two patches were a bit more involved before (I didn't arrive at their current form for quite a few hours), so I guess it could makes sense to just squash them into one patch. Whichever is preferable.
-- Cheers, Sverre Rabbelier