Re: [PATCH 1/5] General configuration portability (Resend)
- From
Sverre Rabbelier <srabbelier@gmail.com>
- Date
- Mar 12, 2010, 07:22 UTC
- Message-ID
- <fabb9a1e1003112322l73cd8f93wffb1829f7988c22a@mail.gmail.com>
- In-Reply-To
- <20100312062308.GI7877@thor.il.thewrittenword.com>
Heya,
On Fri, Mar 12, 2010 at 07:23, Gary V. Vaughan <git@mlists.thewrittenword.com> wrote:
Show 5 quoted lines
> My employer kindly agreed to donate a little of my paid time to push > the git patches we require to build on our supported hosts back > upstream. There is certainly some good stuff in here that is useful > outside of our environment, but I have another 1600 packages to port > too...
While understandable, I hope your employer also understands that just dumping a large patch upstream and tell them "have fun with it" does not a good open source contribution make? Consider the time balance: the investment required for us to figure out whether this patch is any good for git, (not being familiar with the changes you're introducing, and probably unable to test them since we lack the setup), and the time it will cost you to split up the patches into an easily reviewable series. I hope you (and your employer?) will agree that it'd be less time for you to do so, than for us :).
Of course, if your employer is more like "pointy-haired boss" there's not much you can do either.
-- Cheers, Sverre Rabbelier