Re: [RFCv4 3/5] 2/2: Add Python support library for CVS remote helper

From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Oct 5, 2009, 14:50 UTC
Message-ID: <fabb9a1e0910050750q195bdafv5511915fe5d26c02@mail.gmail.com>
In-Reply-To: <200910051641.43136.johan@herland.net>

Heya,

On Mon, Oct 5, 2009 at 16:41, Johan Herland <johan@herland.net> wrote:

> - Are you planning to share directory structure only, or some of the
> Python code as well? From the above structure it seems like you want to
> make use of e.g. util.py and git.py. I'd be delighted if the code is
> reusable by other remote helpers.

Yes, the main reason I suggested this was because I want to reuse util.py and git.py :). Of course, it'd probably be cleaner to move the little CVS-specific code that is in git.py atm out of it.

> - Do you plan to put the remote helpers into this structure as well, or
> keep them separate? (currently the cvs remote helper lives separately
> in git-remote-cvs.py in the project root directory)

I think it's good where it is right now, and I've also placed git-remote-hg.py in the root directory.

Show 8 quoted lines

>> I'm willing to spend some time to do the needed refactoring, but IIUC
>> Daniel said that you need to reroll the cvs series anyway?
>
> Yeah, a re-roll was planned once the sr/gfi-options work was finalized.
> (right now I'm mostly focused on the jh/notes work). Feel free to post
> the hg-specific and/or common parts as a separate patch, and I can
> rebase the CVS series on top of that before I submit the next
> iteration.

Yeah, I'm waiting on Shawn to decide what should be done with the whole options thing before I resubmit sr/gfi-options.

> Nice to see people starting to pick up the foreign-vcs work. :)

Now if only we could bribe Eric to write a svn helper :).

-- 
Cheers,

Sverre Rabbelier