Re: [PATCH] Remove various dead assignments and dead increments found by the clang static analyzer
- From
Sverre Rabbelier <srabbelier@gmail.com>
- Date
- Sep 26, 2009, 18:34 UTC
- Message-ID
- <fabb9a1e0909261134qd90dba1n9637fe4adc253fc1@mail.gmail.com>
- In-Reply-To
- <871vltefdj.fsf@master.homenet>
Heya,
On Sat, Sep 26, 2009 at 20:21, Giuseppe Scrivano <gscrivano@gnu.org> wrote:
> probably this is not the only case to leave as it is. I just cleaned > anything clang reported.
Then it would probably have been better to say so by at least marking your patch as RFC and including such a remark in the cover letter, no? Also, now that this has been pointed out, you shouldn't expect it to be included until someone either takes your patch and cleans it up (as in, checks all statements manually), or until you do so yourself.
-- Cheers, Sverre Rabbelier