Re: [RFH] rebase -i optimization
- From
Sverre Rabbelier <srabbelier@gmail.com>
- Date
- Feb 26, 2009, 15:33 UTC
- Message-ID
- <fabb9a1e0902260733k26e5c02i75a7866f9a67530b@mail.gmail.com>
- In-Reply-To
- <alpine.DEB.1.00.0902261557300.6258@intel-tinevez-2-302>
Heya,
On Thu, Feb 26, 2009 at 15:59, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> This code is supposed to do exactly what you want:
Hmmm, I can't say I understand it 100%, but what I can see from reading the code and looking at the output of 'rebase -i -v' is that it does a 'git reset --hard' on each commit if it was already applied, instead of figuring out beforehand what to reset to? If that is the case, it might still take a long time to do the rebase if it takes long to do the 'reset --hard' between the patches (say, if a big change is made).
> Unfortunately, it seems to be quite broken by all the different directions > rebase -i was pulled to, but maybe you see the bug right away. Otherwise, > I'll try to reschedule my Git time budget later tonight.
After reading the code and trying with -v, I don't think the current code is broken, just that it might be optimized to be even faster?
-- Cheers, Sverre Rabbelier