Re: [PATCH 00/52] fix some -Wmissing-field-initializer warnings

From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: May 24, 2019, 23:08 UTC
Message-ID: <fa9f98b0-5f8f-1d0e-9a87-70fed69520c1@ramsayjones.plus.com>
In-Reply-To: <87a7fbfptk.fsf@evledraar.gmail.com>

On 24/05/2019 23:30, Ævar Arnfjörð Bjarmason wrote:

Show 22 quoted lines

> 
> On Fri, May 24 2019, Ramsay Jones wrote:
> 
>> [No, I won't be sending 52 patches to the list!]
>> [...]
>> This series does not fix any problems or add any new features, so it
>> is not important (hence the tendency to 'slip'). I don't want to
>> flood the mailing list with patches that nobody wants, so: is there
>> any interest in these kinds of patches? If not, I will stop now!
>> (I have a 2-3 year old branch that addressed the '-Wsign-compare'
>> warnings, but that is probably beyond salvaging by now :( ).
>>
>> This series is available from: git://repo.or.cz/git/raj.git with the
>> branch name 'warn-master'. A trial merge to current 'next' and 'pu'
>> branches can be found at 'warn-next' and 'warn-pu' branches. (The
>> merge to 'next' went without problem, and 'pu' only required a fixup
>> to the builtin/commit patch).
>> [...]
>> What do you think?
> 
> I think just send it to the list. We've seen worse, and it's easier to
> review than needing to get out of the normal E-Mail workflow.

I forgot to mention that this series has a long tail. The first ten patches (in addition to all pedantic warnings) removes 1246 warnings. The next 10 removes another 70 and the final 32 patches only removes 55 warnings (the last 18 patches remove only one warning each).

Hmm, so maybe I should only send the first few out?

I will give it some thought (while waiting for some more comments).

Thanks.

ATB, Ramsay Jones