Re: [PATCH v2 0/5] contrib/subtree/Makefile: Standardisation pass

From: James Denholm <nod.helm@gmail.com>
Date: May 6, 2014, 21:46 UTC
Message-ID: <fa80985d-6420-4eb5-8623-00e2d8e8e798@email.android.com>
In-Reply-To: <xmqq7g5yehf4.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> wrote:

>It is funny to see sign-off on 0/5 ;-)

Yeah, I wasn't quite sure of exact protocol, and sort-of defaulted to sign-all-the-things mode.

>By the way, this is v3, not v2, no?  It was somewhat confusing to
>see Peff saying "filfre to add my reviewed-by" on v2, noticing you
>posted something new, and not finding v3.

Ah, right. I thought that resending a post-discussion patch was the done thing, given Documentation/SubmittingPatches, but that a comment line might not have been worth a version bump.

>Will queue.  Thanks.

Awesome, thanks.

Regards, James Denholm.