Re: v2.46.0-rc0 test failures on cygwin
- From
Ramsay Jones <ramsay@ramsayjones.plus.com>
- Date
- Jul 18, 2024, 01:22 UTC
- Message-ID
- <f97198e1-bfcc-4f3c-ad0a-2dd27d4f20cf@ramsayjones.plus.com>
- In-Reply-To
- <20240718005723.GA675057@coredump.intra.peff.net>
On 18/07/2024 01:57, Jeff King wrote:
> On Wed, Jul 17, 2024 at 07:05:43PM +0100, Ramsay Jones wrote:
[snip]
Show 9 quoted lines
>> I also don't know the code well enough to answer your question regarding >> the re-opening of the migrated ref-store, but it doesn't look like it would >> cause any problems (famous last words). > > Thanks for testing. This is new in the upcoming release, but I think > it's localized to the "git ref migrate" command. So aside from the > annoyance of the test failure for you, it is not too urgent. I'm tempted > to put it off until Patrick has had a chance to weigh in, even if it > means missing the v2.46 cutoff.
Yes, I think it would be better for Patrick to take a look. I added Adam to the CC list to keep him in the loop (because he is the cygwin git package maintainer); he may have a view on the timing issues.
Personally, I would be fine with a post v2.46 fix, but it is not up to me. :)
Thanks.
ATB, Ramsay Jones