Re: [PATCH] gitweb: New cgi parameter: filter

From: Jakub Narebski <jnareb@gmail.com>
Date: Jul 11, 2007, 21:19 UTC
Message-ID: <f73hhc$uo1$1@sea.gmane.org>
In-Reply-To: <20070708013543.GD29994@genesis.frugalware.org>

[Cc: git@vger.kernel.org]

Miklos Vajna wrote:

> +               ((defined $filter and $filter == "nomerges") ? ("--no-merges") : ()),

Shouldn't it be '$filter eq "nomerges"' instead?

Besides, I'd rather have generalized way to provide additional options to git commands, like '--no-merges' for RSS and Atom feeds, log, shortlog and history views, '-C' for commitdiff view, '--remove-empty' for history view for a file, perhaps even '-c' or '--cc' for commitdiff for merges instead of abusing 'hp' argument for that.

But that doesn't mean that this patch should be not applied... it doesn't mean it should be applied neither ;-)

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git