Re: [PATCH 3/3] rev-parse: handle --end-of-options
- From
- Demi M. Obenour <demiobenour@gmail.com>
- Date
- Nov 10, 2020, 22:28 UTC
- Message-ID
- <f6736e4b-679b-437a-8768-2352efbb4274@gmail.com>
- In-Reply-To
- <xmqqr1p06ec9.fsf@gitster.c.googlers.com>
On 11/10/20 5:23 PM, Junio C Hamano wrote:
Show 17 quoted lines
> Jeff King <peff@peff.net> writes: > >> This patch lets callers write: >> >> git rev-parse --end-of-options "$rev" -- "$path" >> >> and: >> >> git rev-parse --verify --end-of-options "$rev" >> >> which will both treat "$rev" always as a revision parameter. > > Nice. The only iffy case I can think of is that we can never have > "--" to specify a rev, because with "git cmd -- -- path" we don't > know which double-dash among the two is the disambiguator that makes > the other double-dash to be either rev or path, but that is not a > new problem with this change.
I think Git should at least reject refs named "--", since they cause problems in so many places.
Sincerely,
Demi