Re: Git 1.3.2 on Solaris

From: Stefan Pfetzing <stefan.pfetzing@gmail.com>
Date: May 23, 2006, 12:04 UTC
Message-ID: <f3d7535d0605230504k51b5fc47yc75cf559cb1cc87b@mail.gmail.com>
In-Reply-To: <8157.1148359875@lotus.CS.Berkeley.EDU>

Hi Jason,

2006/5/23, Jason Riedy <ejr@eecs.berkeley.edu>:

Show 8 quoted lines

> This is explicitly allowed by the SUS, even for non-root:
>   http://www.opengroup.org/onlinepubs/000095399/functions/access.html
> For non-root, some ACL systems could allow you to execute
> the file even if there are no execute bits.  What a joy
> ACLs are.  Or NFS uid mappings could play tricks on you,
> or...  And as you've noticed, this kills [ -x ].  (Failing
> to run the hooks in receive-pack.c is noisy but not fatal.
> It's the shell scripts that stop.)

Yup, but this breaks test t5400 - I think because of the post-update hook is failing.

Show 5 quoted lines

> I think you're stuck.  To disable the hooks for all possible
> users, OSes, file systems, etc., you need to remove them.
>
> Or just don't run as root, and hope that the OS isn't
> completely insane.

As non-root it works fine.

> BTW, ERR_RUN_COMMAND_EXEC is never returned.  Any failure
> to exec will produce an exit code of 128 from die.  This
> will be an issue when commit becomes a built-in, right?

Think so.

bye

Stefan

-- 
       http://www.dreamind.de/
Oroborus and Debian GNU/Linux Developer.