Re: [PATCH] auto-detect changed $prefix in Makefile and properly rebuild to avoid broken install
- From
- Yakov Lerner <iler.ml@gmail.com>
- Date
- Jun 15, 2006, 11:11 UTC
- Message-ID
- <f36b08ee0606150411q67fce728vad6dc0403160f95a@mail.gmail.com>
- In-Reply-To
- <E1Fqo70-0003pZ-PU@moooo.ath.cx>
On 6/15/06, Matthias Lederhofer <matled@gmx.net> wrote:
Show 5 quoted lines
> > Either GIT-CFLAGS or GIT-BUILD-FLAGS, > > whichever is shorter :-) > > I would not take GIT-CFLAGS because there is an environment variable > used by make named CFLAGS and means something else.
What is your preference for this filename ? Is GIT-BUILD-FLAGS better ? GIT-FLAGS ? Other ?
GIT-CFLAGS is filename here, whereas $(CFLAGS) is variable. Maybe writing it the filename ./GIT-CFLAGS would emphasize betterthat it's not make variable, but a filename ?
> What is the target test-prefix-change good for? Should it really be > included?
The purpose of 'test-prefix-change' is to check that there are no missing GIT-FLAGS as prerequisite which would result in broken install if prefix changed between 'make' and 'make install'. The 'make test-prefix-change' would catch it if GIT-FLAGS happened to be missing in some places that if substantially dependent of $prefix.
Yakov