git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] builtin/index-pack.c: fix some sparse warnings

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Aug 27, 2020, 00:40 UTC
Message-ID
<f2c8b658-f9d8-43bd-7121-9e0f04adeb4b@ramsayjones.plus.com>
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Jonathan,

If you need to re-roll your 'jt/threaded-index-pack' branch, could you please squash this into the relevant patch (commit 4a03e3d995 (index-pack: make quantum of work smaller, 24-08-2020)).

Thanks!

ATB, Ramsay Jones

 builtin/index-pack.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/builtin/index-pack.c b/builtin/index-pack.c
index 3a20017102..8acd078aa0 100644
--- a/builtin/index-pack.c
+++ b/builtin/index-pack.c
@@ -65,7 +65,7 @@ struct base_data {
  *
  * Guarded by work_mutex.
  */
-LIST_HEAD(work_head);
+static LIST_HEAD(work_head);
 
 /*
  * Stack of struct base_data that have children, all of whom have been
@@ -75,7 +75,7 @@ LIST_HEAD(work_head);
  *
  * Guarded by work_mutex.
  */
-LIST_HEAD(done_head);
+static LIST_HEAD(done_head);
 
 /*
  * All threads share one delta base cache.
@@ -83,8 +83,8 @@ LIST_HEAD(done_head);
  * base_cache_used is guarded by work_mutex, and base_cache_limit is read-only
  * in a thread.
  */
-size_t base_cache_used;
-size_t base_cache_limit;
+static size_t base_cache_used;
+static size_t base_cache_limit;
 
 struct thread_local {
 	pthread_t thread;
-- 
2.28.0
Message 1 of 1 in “builtin/index-pack.c: fix some sparse warnings”
  1. builtin/index-pack.c: fix some sparse warningsRamsay Jones, Aug 27, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.