Re: [PATCH RESEND] branch: allow deleting dangling branches with --force

From: René Scharfe <l.s.r@web.de>
Date: Aug 26, 2021, 18:18 UTC
Message-ID: <f2511e9a-cc0f-20d0-d196-5dacdd637b7d@web.de>
In-Reply-To: <CAFQ2z_Mwj0+uWO-Ly8MTHmidjf=1P-9K1n2f0DSNzN=Or2t=bw@mail.gmail.com>

Am 26.08.21 um 09:26 schrieb Han-Wen Nienhuys:

Show 11 quoted lines

> On Wed, Aug 25, 2021 at 11:37 PM Junio C Hamano <gitster@pobox.com> wrote:
>
>>> +test_expect_success 'branch --delete --force removes dangling branch' '
>>> +     test_when_finished "rm -f .git/refs/heads/dangling" &&
>>> +     echo $ZERO_OID >.git/refs/heads/dangling &&
>>> +     git branch --delete --force dangling &&
>>> +     test_path_is_missing .git/refs/heads/dangling
>>> +'
>>
>> This goes against the spirit of the series merged at c9780bb2 (Merge
>> branch 'hn/prep-tests-for-reftable', 2021-07-13).

I assume the file backend won't go away anytime soon. So I guess the idea is that the test suite is supposed to be run with the new backend as default and exercise it?

>> Can we creat the dangling ref and test the lack of "dangling" ref in
>> the end in a less transparent way?
>
> agreed. Try the ref-store test-helper's update-ref command?

It requires the new hash to refer to an existing object, so we can't use it in this test.

René