git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 17/26] bisect--helper: retire `--check-expected-revs` subcommand

From
Pranit Bauva via GitGitGadget <gitgitgadget@gmail.com>
Date
Feb 24, 2019, 10:11 UTC
Message-ID
<f1db62c3235e5d91a21b3f7b92c5aece8b65f600.1551003074.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.117.git.gitgitgadget@gmail.com>
From: Pranit Bauva <pranit.bauva@gmail.com>

The `--check-expected-revs` subcommand is no longer used in the shell script and the function `check_expected_revs()` is called from the C implementation of `bisect_next()`.

Mentored-by: Lars Schneider <larsxschneider@gmail.com>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Mentored-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
Signed-off-by: Tanushree Tumane <tanushreetumane@gmail.com>
---
 builtin/bisect--helper.c | 6 ------
 1 file changed, 6 deletions(-)
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index 49ef0ff6bc..9cc11450f4 100644
--- a/builtin/bisect--helper.c
+++ b/builtin/bisect--helper.c
@@ -892,7 +892,6 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
 {
 	enum {
 		WRITE_TERMS = 1,
-		CHECK_EXPECTED_REVS,
 		BISECT_RESET,
 		BISECT_WRITE,
 		CHECK_AND_SET_TERMS,
@@ -908,8 +907,6 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
 	struct option options[] = {
 		OPT_CMDMODE(0, "write-terms", &cmdmode,
 			 N_("write the terms to .git/BISECT_TERMS"), WRITE_TERMS),
-		OPT_CMDMODE(0, "check-expected-revs", &cmdmode,
-			 N_("check for expected revs"), CHECK_EXPECTED_REVS),
 		OPT_CMDMODE(0, "bisect-reset", &cmdmode,
 			 N_("reset the bisection state"), BISECT_RESET),
 		OPT_CMDMODE(0, "bisect-write", &cmdmode,
@@ -950,9 +947,6 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
 		if (argc != 2)
 			return error(_("--write-terms requires two arguments"));
 		return write_terms(argv[0], argv[1]);
-	case CHECK_EXPECTED_REVS:
-		check_expected_revs(argv, argc);
-		return 0;
 	case BISECT_RESET:
 		if (argc > 1)
 			return error(_("--bisect-reset requires either no argument or a commit"));
-- 
gitgitgadget
Previous: Pranit Bauva via GitGitGadgetNext: Pranit Bauva via GitGitGadget
Message 19 of 27 in “Git bisect part3”
  1. 00/26 Git bisect part3Tanushree Tumane via GitGitGadget, Feb 24, 2019
  2. 01/26 bisect--helper: refer branch.buf before strbuf_release(...)Tanushree Tumane via GitGitGadget, Feb 24, 2019
  3. 02/26 bisect--helper: change `retval` to `res`Tanushree Tumane via GitGitGadget, Feb 24, 2019
  4. 05/26 bisect.c: libify `bisect_checkout` and its dependantsPranit Bauva via GitGitGadget, Feb 24, 2019
  5. 04/26 bisect.c: libify `exit_if_skipped_commits` to `error_if_skipped...`Pranit Bauva via GitGitGadget, Feb 24, 2019
  6. 06/26 bisect.c: libify `check_merge_bases` and its dependents.Pranit Bauva via GitGitGadget, Feb 24, 2019
  7. 08/26 bisect.c: libify `handle_bad_merge_base` and its dependantsPranit Bauva via GitGitGadget, Feb 24, 2019
  8. 07/26 bisect.c: libify `check_good_are_ancestors_of_bad` and its dependentsPranit Bauva via GitGitGadget, Feb 24, 2019
  9. 09/26 bisect.c: libify `bisect_next_all` and its dependantsPranit Bauva via GitGitGadget, Feb 24, 2019
  10. 11/26 bisect--helper: Finish `bisect_start()` conversionPranit Bauva via GitGitGadget, Feb 24, 2019
  11. 12/26 bisect--helper: dequote arguments in `bisect-start`Pranit Bauva via GitGitGadget, Feb 24, 2019
  12. 10/26 bisect--helper: `bisect_next` and `bisect_auto_next` shell function in CPranit Bauva via GitGitGadget, Feb 24, 2019
  13. 03/26 bisect--helper: `decide_next()` helper function.Tanushree Tumane via GitGitGadget, Feb 24, 2019
  14. 23/26 bisect--helper: retire `--bisect-auto-next` subcommandPranit Bauva via GitGitGadget, Feb 24, 2019
  15. 21/26 bisect--helper: retire `--bisect-write` subcommandPranit Bauva via GitGitGadget, Feb 24, 2019
  16. 20/26 bisect--helper: `bisect_replay` shell function in CPranit Bauva via GitGitGadget, Feb 24, 2019
  17. 22/26 bisect--helper: retire `--bisect-autostart` subcommandPranit Bauva via GitGitGadget, Feb 24, 2019
  18. 19/26 bisect--helper: `bisect_log` shell function in CPranit Bauva via GitGitGadget, Feb 24, 2019
  19. 17/26 bisect--helper: retire `--check-expected-revs` subcommandPranit Bauva via GitGitGadget, Feb 24, 2019
  20. 18/26 bisect--helper: retire `--write-terms` subcommandPranit Bauva via GitGitGadget, Feb 24, 2019
  21. 16/26 bisect--helper: `bisect_state` & `bisect_head` shell function in CPranit Bauva via GitGitGadget, Feb 24, 2019
  22. 24/26 bisect--helper: remove the dequote in bisect_start()Pranit Bauva via GitGitGadget, Feb 24, 2019
  23. 25/26 bisect--helper: `bisect_skip` shell function in CPranit Bauva via GitGitGadget, Feb 24, 2019
  24. 15/26 bisect--helper: `bisect_autostart` shell function in CPranit Bauva via GitGitGadget, Feb 24, 2019
  25. 26/26 bisect--helper: retire `--check-and-set-terms` subcommandPranit Bauva via GitGitGadget, Feb 24, 2019
  26. 14/26 bisect--helper: retire `--next-all` subcommandPranit Bauva via GitGitGadget, Feb 24, 2019
  27. 13/26 bisect--helper: retire `--bisect-clean-state` subcommandPranit Bauva via GitGitGadget, Feb 24, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.