git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/5] builtin-log.c: Use 'git_config_string' to get 'format.subjectprefix' and 'format.suffix'

From
Brian Hetro <whee@smaertness.net>
Date
Jul 5, 2008, 05:24 UTC
Message-ID
<f1c8159441e6afc5021e5f087f6feaf5b53e61df.1215234749.git.whee@smaertness.net>
In-Reply-To
<fd5cae53021281c920ba48efef82dc8a8d3c7fe1.1215234749.git.whee@smaertness.net>
Signed-off-by: Brian Hetro <whee@smaertness.net>
---
 builtin-log.c |   16 ++++------------
 1 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/builtin-log.c b/builtin-log.c
index 9979e37..430d876 100644
--- a/builtin-log.c
+++ b/builtin-log.c
@@ -234,12 +234,8 @@ static int git_log_config(const char *var, const char *value, void *cb)
 {
 	if (!strcmp(var, "format.pretty"))
 		return git_config_string(&fmt_pretty, var, value);
-	if (!strcmp(var, "format.subjectprefix")) {
-		if (!value)
-			config_error_nonbool(var);
-		fmt_patch_subject_prefix = xstrdup(value);
-		return 0;
-	}
+	if (!strcmp(var, "format.subjectprefix"))
+		return git_config_string(&fmt_patch_subject_prefix, var, value);
 	if (!strcmp(var, "log.date"))
 		return git_config_string(&default_date_mode, var, value);
 	if (!strcmp(var, "log.showroot")) {
@@ -489,12 +485,8 @@ static int git_format_config(const char *var, const char *value, void *cb)
 		add_header(value);
 		return 0;
 	}
-	if (!strcmp(var, "format.suffix")) {
-		if (!value)
-			return config_error_nonbool(var);
-		fmt_patch_suffix = xstrdup(value);
-		return 0;
-	}
+	if (!strcmp(var, "format.suffix"))
+		return git_config_string(&fmt_patch_suffix, var, value);
 	if (!strcmp(var, "format.cc")) {
 		if (!value)
 			return config_error_nonbool(var);
-- 
1.5.6.1.204.g699135
Previous: Brian HetroNext: Brian Hetro
Message 3 of 7 in “git_config_string janitorial conversions.”
  1. 0/5 git_config_string janitorial conversions.Brian Hetro, Jul 5, 2008
  2. 1/5 builtin-commit.c: Use 'git_config_string' to get 'commit.template'Brian Hetro, Jul 5, 2008
  3. 2/5 builtin-log.c: Use 'git_config_string' to get 'format.subjectprefix' and 'format.suffix'Brian Hetro, Jul 5, 2008
  4. 3/5 convert.c: Use 'git_config_string' to get 'smudge' and 'clean'Brian Hetro, Jul 5, 2008
  5. 4/5 diff.c: Use 'git_config_string' to get 'diff.external'Brian Hetro, Jul 5, 2008
  6. 5/5 http.c: Use 'git_config_string' to clean up SSL config.Brian Hetro, Jul 5, 2008
  7. Christian CouderJul 6, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.