Re: cvsserver and wincvs (cvsgui)

From: Jakub Narebski <jnareb@gmail.com>
Date: Apr 13, 2007, 00:11 UTC
Message-ID: <evmhk0$p0l$1@sea.gmane.org>
In-Reply-To: <Pine.LNX.4.64.0704121821150.27922@iabervon.org>

[Cc: Daniel Barkalow <barkalow@iabervon.org>, git@vger.kernel.org]

Daniel Barkalow wrote:

Show 6 quoted lines

> I'm having problems using git-cvsserver to support a wincvs user. It seems 
> to be truncating binary files in both directions (e.g., we have a PNG that 
> starts, in hex, 89 50 4e 47 0d 0a ..., and it gets truncated between the 
> 0d and 0a), and it seems to fail up-to-date checks when checking in files 
> that are, in fact, up-to-date (and, so far as I can see, haven't been 
> modified anywhere else).

Which version of git do you use?

In git-cvsserner(1) (but not in git-config(1)) we have:

  The server should set the '-k' mode to binary when relevant, however,
  this is not really implemented yet. For now, you can force the server
  to set '-kb' for all files by setting the `gitcvs.allbinary` config
  variable. In proper GIT tradition, the contents of the files are
  always respected. No keyword expansion or newline munging is supported.

Do you have gitcvs.allbinary set?

By the way, gitweb used to have the same problem. It was fixed by using :raw mode for outputting binary files, instead of set by default :utf8 (see commit f5aa79d909f8c4838bf5).

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git