git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] remove "[PATCH]" prefix from shortlog output

From
Jakub Narebski <jnareb@gmail.com>
Date
Dec 10, 2006, 23:10 UTC
Message-ID
<eli3vr$j6v$1@sea.gmane.org>
In-Reply-To
<Pine.LNX.4.63.0612102337090.28348@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin wrote:
Show 23 quoted lines
> On Sat, 9 Dec 2006, Nicolas Pitre wrote:
> 
>> This doesn't convey much information in the shortlog context.
>> And the perl version did strip it as well.
> 
> From the current builtin-shortlog.c:128ff:
> 
>         if (!strncmp(oneline, "[PATCH", 6)) {
>                 char *eob = strchr(oneline, ']');
> 
>                 if (eob) {
>                         while (isspace(eob[1]) && eob[1] != '\n')
>                                 eob++;
>                         if (eob - oneline < onelinelen) {
>                                 onelinelen -= eob - oneline;
>                                 oneline = eob;
>                         }
>                 }
>         }
> 
> It tries not only to strip "[PATCH]", but also "[PATCH 0/n]" and basically 
> every prefix beginning with "[PATCH" and ending in "]". I do not remember 
> if I really tested that code, but it should work.

What happens if you have "[PATCH" without closing "]"? Does it work (and doesn't crash)? Does it strip anything?

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 3 of 7 in “remove "[PATCH]" prefix from shortlog output”
  1. remove "[PATCH]" prefix from shortlog outputNicolas Pitre, Dec 10, 2006
  2. Johannes SchindelinDec 10, 2006
  3. Jakub NarebskiDec 10, 2006
  4. Johannes SchindelinDec 10, 2006
  5. Junio C HamanoDec 10, 2006
  6. Johannes SchindelinDec 10, 2006
  7. Nicolas PitreDec 11, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.