Re: [WISH] Store also tag dereferences in packed-refs

From: Jakub Narebski <jnareb@gmail.com>
Date: Nov 19, 2006, 21:24 UTC
Message-ID: <ejqhvi$9kc$1@sea.gmane.org>
In-Reply-To: <Pine.LNX.4.64.0611191310430.3692@woody.osdl.org>

Linus Torvalds wrote:

Show 17 quoted lines

> On Sun, 19 Nov 2006, Junio C Hamano wrote:
>> 
>> Did you do this "if (isspace(*line)) return NULL" to have
>> extensibility later, I wonder...
> 
> No, but I try to have a policy of not accepting anything that is even 
> slightly questionable, so it was unintentional in the details but a result 
> of a higher-level principle..
> 
> Of course, even when I wrote it I _also_ knew that I should check 
> everything else too (not just the first character), but I was lazy. That 
> would have been even better - then we could have made the thing be 
> something like
> 
>       <sha1><space><name>[<space><sha1-of-deref>]*
> 
> instead.

So the only reason against this format (IMHO more reasonable, more readable and more readable, and even easy extendable to the whole chain of derefs) is code in the wild?

By the way, do we copy packed refs literaly when fetching or cloning?

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git