Re: [PATCH] Allow hand-editing of patches before sending

From: Jakub Narebski <jnareb@gmail.com>
Date: Nov 5, 2006, 19:29 UTC
Message-ID: <eile19$p7r$1@sea.gmane.org>
In-Reply-To: <20061105190400.GC25259@diana.vm.bytemark.co.uk>

Karl Hasselström wrote:

Show 8 quoted lines

> These are the headers that StGIT uses without my patch -- that is, the
> headers used to get that error message:
> 
>   Content-Type: text/plain; charset=utf-8; format=fixed
>   Content-Transfer-Encoding: 8bit
> 
> Which is obviously not good enough for some picky part of the SMTP
> chain.

I think you are missing MIME-Version: header.

[...]

Show 7 quoted lines

> Well, it added these headers:
> 
>   MIME-Version: 1.0
>   Content-Transfer-Encoding: QUOTED-PRINTABLE
>   Content-Type: TEXT/PLAIN; charset=ISO-8859-1
> 
> Maybe MIME-Version was the only thing missing? I'll have to try.

MIME-Version _is_ important. I remember that Outlook Express sent news messages without this header, and those posts were either mangled by news server, or news readers didn't parse MIME headers without MIME-Version:

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git