Re: git_get_projects_list and $projects_list

From: Jakub Narebski <jnareb@gmail.com>
Date: Oct 31, 2006, 12:23 UTC
Message-ID: <ei7f7o$bgi$1@sea.gmane.org>
In-Reply-To: <ei7dq4$828$1@sea.gmane.org>

Jakub Narebski wrote:

Show 12 quoted lines

> Aneesh Kumar wrote:
> 
>> Ok if i have
>> 
>> $projects_list = "/a/git////" ==> ending "/" . the function will fail
>> at check_export_ok()
>> 
>> That is because we get the $pfxlen wrong. We should ignore all the trailing "/"
>> my $subdir = substr($File::Find::name, $pfxlen + 1);
> 
> Perhaps it would be enough to just add 
>         $dir =~ s!/+$//;

Ooops, it should of course be

        $dir =~ s!/+$!!;

> before  
>         my $pfxlen = length("$dir");
> (or something equivalent). Try it and send us a patch.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git