Re: [PATCH] gitweb: Show project README if available

From: Jakub Narebski <jnareb@gmail.com>
Date: Oct 10, 2006, 09:00 UTC
Message-ID: <egfndo$lg6$1@sea.gmane.org>
In-Reply-To: <20061010025627.19317.70511.stgit@rover>

Petr Baudis wrote:

> +                       print $_ while (<$fd>);

Wouldn't it be better to do it in slurp mode, i.e.

        {
                local $/
                print <$fd>;
        }

instead?

Do you assume that README is HTML fragment? If not, you should esc_html it. Besides, we have similar (if assumed to have one line only) file, namely description.

Besides, README for a project can be huge. Git README has 589 lines!

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git