Re: [PATCH] gitweb: Decode long title for link tooltips
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Oct 1, 2006, 16:45 UTC
- Message-ID
- <eforb7$fgd$1@sea.gmane.org>
- In-Reply-To
- <87zmcmroqf.wl@mail2.atmark-techno.com>
Yasushi SHOJI wrote:
Show 6 quoted lines
> This is a simple one liner to decode long title string in perl's > internal form to utf-8 for link tooltips. > > This is not crucial if the commit message is all in ASCII, however, if > you decide to use other encoding, such as UTF-8, tooltips ain't > readable any more.
Perhaps it would be better to abstract it away into esc_attr (as escape attribute) subroutine, if such situation i.e. output of generated string into some attribute of some element happens in some other place.
-- Jakub Narebski Warsaw, Poland ShadeHawk on #git