Re: Re* [RFH] adding test coverage for contrib/ in CI jobs

From: Colin Stagner <ask+git@howdoi.land>
Date: Feb 5, 2026, 06:05 UTC
Message-ID: <ef128e1d-dd3e-4573-bfcd-6a98a0a1f394@howdoi.land>
In-Reply-To: <xmqqjywtu58j.fsf_-_@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 8 quoted lines

> Unfortunately, this seems to reveal existing other problems with
> subtree tests (t7900), in addition to diff-highlight tests (t9400)
> in various configurations.
> 
> https://github.com/git/git/actions/runs/21617099884
> 
> This Ci run is near the tip of 'seen', so there may be breakages
> attributable to new topics in flight

At least some of the subtree failures on linux-reftable, such as

<https://github.com/git/git/actions/runs/21617099884/job/62298228602#step:10:421>

are actually due to a bug in ubuntu:rolling's "dirname" implementation. This was fixed upstream in late January [1].

bug behavior demo:

     podman run --rm -it -q docker.io/library/ubuntu:questing-20251217 \
       dirname whatever/.

outputs "whatever"

     podman run --rm -it -q docker.io/library/ubuntu:25.10 \
       dirname whatever/.

outputs "."

subtree has an up-front call to

     dir="$(dirname "$arg_prefix/.")"

which encounters the defect. It then attempts to do things like

     git read-tree --prefix=. $someref

that error out with messages like "error: invalid path './sub1'"

[1]: https://github.com/uutils/coreutils/issues/10508