Re: [PATCH] gitweb: more support for PATH_INFO based URLs

From: Jakub Narebski <jnareb@gmail.com>
Date: Sep 17, 2006, 13:18 UTC
Message-ID: <eejhtr$paa$1@sea.gmane.org>
In-Reply-To: <20060916210832.GV17042@admingilde.org>

Martin Waitz wrote:

Show 8 quoted lines

> Now three types of path based URLs are supported:
>       gitweb.cgi/project.git
>       gitweb.cgi/project.git/branch
>       gitweb.cgi/project.git/branch/filename
> 
> The first one (show project summary) was already supported for a long time
> now.  The other two are new: they show the shortlog of a branch or
> the plain file contents of some file contained in the repository.

Show 10 quoted lines

> +     if ($path_info =~ m,^$project/([^/]+)/(.+)$,) {
> +             # we got "project.git/branch/filename"
> +             $action    ||= "blob_plain";
> +             $hash_base ||= $1;
> +             $file_name ||= $2;
> +     } elsif ($path_info =~ m,^$project/([^/]+)$,) {
> +             # we got "project.git/branch"
> +             $action ||= "shortlog";
> +             $hash   ||= $1;
> +     }

I'm sorry, but I realized that I didn't think and check this patch through.

First, this patch spews a bunch of warnings: when PATH_INFO is empty, when we undefine $project etc. The patches by me and by matled try to address and remove those warnings, but I'm sure we missed some.

Second, the whole concept of third type of path (path_info) based URL is flawed: branches can also be hierarchical (for example Junio uses <initals>/<topic> topic branches, although they are not published). Therefore it is much harder to distinguish where branchname ends and filename begins. The patch assumes that branches are flat. So for example for branch with the name like "gitweb/xmms2" the types 2 and 3 wouldn't work; and type 1 worked before this patch.

Therefore I rescind my Ack.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git