Re: [PATCH v2 09/53] builtin/rev-parse: convert to struct object_id
- From
- Jonathan Tan <jonathantanmy@google.com>
- Date
- May 1, 2017, 21:54 UTC
- Message-ID
- <ee83bfa4-ac6d-9ad7-5783-02f42e95dc82@google.com>
- In-Reply-To
- <20170501022946.258735-10-sandals@crustytoothpaste.net>
On 04/30/2017 07:29 PM, brian m. carlson wrote:
Show 15 quoted lines
> @@ -340,7 +340,7 @@ static int try_parent_shorthands(const char *arg)
> }
>
> if (include_rev)
> - show_rev(NORMAL, sha1, arg);
> + show_rev(NORMAL, &oid, arg);
> for (parents = commit->parents, parent_number = 1;
> parents;
> parents = parents->next, parent_number++) {
> @@ -352,7 +352,7 @@ static int try_parent_shorthands(const char *arg)
> if (symbolic)
> name = xstrfmt("%s^%d", arg, parent_number);
> show_rev(include_parents ? NORMAL : REVERSED,
> - parents->item->object.oid.hash, name);
> + & parents->item->object.oid, name);No space after ampersand.
Up to (and including) this patch, looks good. I didn't notice any changes other than introductions of parse_oid_hex() and mechanical changes.