ds/config-literal-value (was Re: What's cooking in git.git (Nov 2020, #06; Mon, 30))

From: Derrick Stolee <stolee@gmail.com>
Date: Dec 2, 2020, 13:22 UTC
Message-ID: <ee7a17a2-25a0-d8c9-f686-4ce3a22616e0@gmail.com>
In-Reply-To: <xmqqtut6qf7q.fsf@gitster.c.googlers.com>

On 12/1/2020 12:15 AM, Junio C Hamano wrote:

Show 16 quoted lines

> * ds/config-literal-value (2020-11-25) 8 commits
>  - config doc: value-pattern is not necessarily a regexp
>  - config: implement --fixed-value with --get*
>  - config: plumb --fixed-value into config API
>  - config: add --fixed-value option, un-implemented
>  - t1300: add test for --replace-all with value-pattern
>  - t1300: test "set all" mode with value-pattern
>  - config: replace 'value_regex' with 'value_pattern'
>  - config: convert multi_replace to flags
>  (this branch is used by ds/maintenance-part-3.)
> 
>  Various subcommands of "git config" that takes value_regex
>  learn the "--literal-value" option to take the value_regex option
>  as a literal string.
> 
>  Expecting a (hopefully final) reroll.

Hi Junio,

Did this expectation of a reroll get updated since v3? My understanding is that any remaining feedback is related to the angle brackets, which are consistent with the surrounding documentation (and should be tackled in a separate series). Do you mean that you want me to update the lines I'm touching to use angle brackets?

Or, do you mean that I should re-roll to include the patch you sent [1] for between patches 7 and 8?

[1] https://lore.kernel.org/git/xmqq7dq9ca94.fsf@gitster.c.googlers.com/

Thanks, -Stolee