git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-checkout: Handle relative paths containing "..".

From
David Symonds <dsymonds@gmail.com>
Date
Nov 8, 2007, 13:10 UTC
Message-ID
<ee77f5c20711080510i138729b9vb0b9ad485cb2db3@mail.gmail.com>
In-Reply-To
<7v4pfx3zs3.fsf@gitster.siamese.dyndns.org>
On Nov 8, 2007 7:30 PM, Junio C Hamano <junio@pobox.com> wrote:
>
> Have you tested this patch from the toplevel of any tree, where
> "git-rev-parse --show-cdup" would yield an empty string?

No, I didn't. Arguably, "git-rev-parse --show-cdup" should always return a path to the top-level, which would make this kind of construction much simpler. Is there anything that relies upon it returning the empty string when you're in the top-level directory?

> I also wonder how this patch (with an obvious fix to address the
> above point) would interact with GIT_DIR and/or GIT_WORK_TREE in
> the environment.

No idea. I'm still learning my way around the git codebase, so I was hoping for some review and feedback from more experienced Gits.

Dave.
Previous: Junio C HamanoNext: Johannes Schindelin
Message 3 of 4 in “git-checkout: Handle relative paths containing "..".”
  1. git-checkout: Handle relative paths containing "..".David Symonds, Nov 8, 2007
  2. Junio C HamanoNov 8, 2007
  3. David SymondsNov 8, 2007
  4. Johannes SchindelinNov 8, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.