Re: [PATCH] git-archive: accept --owner and --group like GNU tar

From: René Scharfe <l.s.r@web.de>
Date: Jan 5, 2018, 13:54 UTC
Message-ID: <ee76246b-579c-fe01-eb9c-d400061b47b6@web.de>
In-Reply-To: <xmqqmv1tfpqh.fsf@gitster.mtv.corp.google.com>

Am 04.01.2018 um 19:22 schrieb Junio C Hamano:

Show 15 quoted lines

> René Scharfe <l.s.r@web.de> writes:
> 
>> I don't know if it's a good idea, but perhaps we don't even need a new
>> option.  We could change how pathspecs of untracked files are handled:
>> Instead of aborting we could include them in the archive.  (Sounds like
>> the simplest possible interface, but may have practical problems.)
> 
> One practical problem is that users who do this
> 
>      $ git archive HEAD Documentation/ | tar tf -
> 
> would be expecting (at least) two different things, depending on the
> situation they are in.
> 
> So at least you'd need an "--include-untracked" option, I guess.

Right, this breaks down with directories -- most build artifacts (e.g. .o files) are probably not meant to end up in archives. We could still do it for regular files and symlinks. Perhaps that's too confusing, though, and an --add-untracked-file parameter (or whatever we want to call it) is the way to go.

René