git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv2 4/4] imap-send: use curl by default

From
Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com>
Date
Aug 8, 2017, 07:48 UTC
Message-ID
<ee64e0d5-49e7-9e6f-a1f0-fea42557e44e@morey-chaisemartin.com>
In-Reply-To
<3637fd31-3120-eca0-b7ee-8e6e324b6b58@morey-chaisemartin.com>

Now that curl is enable by default, use the curl implementation for imap too. The goal is to validate feature parity between the legacy and the curl implementation, deprecate thee legacy implementation later on and in the long term, hopefully drop it altogether.

Signed-off-by: Nicolas Morey-Chaisemartin <nicolas@morey-chaisemartin.com>
---
 imap-send.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/imap-send.c b/imap-send.c
index 5e80edaff..138d776f7 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -35,11 +35,11 @@ typedef void *SSL;
 #include "http.h"
 #endif
 
-#if defined(USE_CURL_FOR_IMAP_SEND) && defined(NO_OPENSSL)
-/* only available option */
+#if defined(USE_CURL_FOR_IMAP_SEND)
+/* Always default to curl if it's available. */
 #define USE_CURL_DEFAULT 1
 #else
-/* strictly opt in */
+/* We don't have curl, so continue to use the historical implementation */
 #define USE_CURL_DEFAULT 0
 #endif
 
-- 
2.14.0.rc1.16.gcc208c97c
Previous: Nicolas Morey-Chaisemartin
Message 7 of 7 in “[PATCHv2 0/4] imap-send: Fix and enable curl by default”
  1. Nicolas Morey-ChaisemartinAug 8, 2017
  2. 1/4 imap-send: return with error if curl failedNicolas Morey-Chaisemartin, Aug 8, 2017
  3. 3/4 imap_send: setup_curl: retreive credentials if not set in config fileNicolas Morey-Chaisemartin, Aug 8, 2017
  4. Martin ÅgrenAug 8, 2017
  5. Nicolas Morey-ChaisemartinAug 8, 2017
  6. 2/4 imap-send: add wrapper to get server credentials if neededNicolas Morey-Chaisemartin, Aug 8, 2017
  7. 4/4 imap-send: use curl by defaultNicolas Morey-Chaisemartin, Aug 8, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.