git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-branch: display "was sha1" on branch deletion rather than just "sha1"

From
Brandon Casey <drafnel@gmail.com>
Date
Mar 22, 2009, 00:09 UTC
Message-ID
<ee63ef30903211709s24f8294dq9ea52bcae72b755a@mail.gmail.com>

Make it more pleasant to read about a branch deletion by adding "was". Jeff King suggested this, and I ignored it. He was right.

Update t3200 test again to match the change in output.
Signed-off-by: Brandon Casey <drafnel@gmail.com>
---
 builtin-branch.c  |    2 +-
 t/t3200-branch.sh |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin-branch.c b/builtin-branch.c
index 14d4b91..07a440e 100644
--- a/builtin-branch.c
+++ b/builtin-branch.c
@@ -171,7 +171,7 @@ static int delete_branches(int argc, const char
**argv, int force, int kinds)
 			ret = 1;
 		} else {
 			struct strbuf buf = STRBUF_INIT;
-			printf("Deleted %sbranch %s (%s).\n", remote,
+			printf("Deleted %sbranch %s (was %s).\n", remote,
 			       bname.buf,
 			       find_unique_abbrev(sha1, DEFAULT_ABBREV));
 			strbuf_addf(&buf, "branch.%s", bname.buf);
diff --git a/t/t3200-branch.sh b/t/t3200-branch.sh
index 61a2010..1b1e9ec 100755
--- a/t/t3200-branch.sh
+++ b/t/t3200-branch.sh
@@ -195,7 +195,7 @@ test_expect_success 'test deleting branch deletes
branch config' \
 test_expect_success 'test deleting branch without config' \
     'git branch my7 s &&
      sha1=$(git rev-parse my7 | cut -c 1-7) &&
-     test "$(git branch -d my7 2>&1)" = "Deleted branch my7 ($sha1)."'
+     test "$(git branch -d my7 2>&1)" = "Deleted branch my7 (was $sha1)."'

 test_expect_success 'test --track without .fetch entries' \
     'git branch --track my8 &&
-- 
1.6.2.12.g83676
Next: Jeff King
Message 1 of 3 in “git-branch: display "was sha1" on branch deletion rather than just "sha1"”
  1. git-branch: display "was sha1" on branch deletion rather than just "sha1"Brandon Casey, Mar 22, 2009
  2. Jeff KingMar 22, 2009
  3. Brandon CaseyMar 22, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.