Re: [PATCH v2 1/2] t7700: demonstrate repack flaw which may loosen objects unnecessarily

From: Brandon Casey <drafnel@gmail.com>
Date: Mar 21, 2009, 23:16 UTC
Message-ID: <ee63ef30903211616pdf9fdal51dda518dd3cfec@mail.gmail.com>
In-Reply-To: <ee63ef30903211525q4a95a27eoa4e95c7954e5cc93@mail.gmail.com>

Man I just can't seem to get a patch off without issues. I meant to put these two comments in the patch emails.

1) Junio, these two patches are on top of 4d6acb70 which was the tip
of your jc/maint-1.6.0-keep-pack branch.

2) Also, note that this issue affects --keep-unreachable too, but the
fix is different since add_objects_in_unpacked_packs() just calls
add_object_entry() to add the unreachable objects to the list of
objects to pack and it (add_object_entry) already iterates on the pack
list.  One way to fix it, which feels very kludgy to me, is to
temporarily set 'local' to one before calling add_object_entry, so
that it will do nothing if the object is found in any non-local pack.
Unless I'm convinced it is worth it, I don't plan on fixing it.  I
doubt anyone uses --keep-unreachable manually.  It was invented to
make git-gc safe and has now been replaced by --unpack-unreachable.
So, --keep-unreachable may pack objects that it doesn't really need to
pack.  I can live with it.

-brandon

On Sat, Mar 21, 2009 at 5:25 PM, Brandon Casey <drafnel@gmail.com> wrote:

Show 7 quoted lines

> If an unreferenced object exists in both a local pack and in either a pack
> residing in an alternate object database or a local kept pack, then the
> pack-objects call made by repack will loosen that object only to have it
> immediately pruned by repack's call to prune-packed.
>
> Signed-off-by: Brandon Casey <drafnel@gmail.com>
> ---