git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFD] gitweb: href() function to generate URLs for CGI

From
Jakub Narebski <jnareb@gmail.com>
Date
Aug 22, 2006, 22:39 UTC
Message-ID
<ecg12q$3uj$1@sea.gmane.org>
In-Reply-To
<7vveokmmpr.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
Show 11 quoted lines
> Jakub Narebski <jnareb@gmail.com> writes:
> 
>> URL for search is created and encoded by browser I think, so search
>> for "a = b" generates
>>
>>         gitweb.cgi?p=git.git&a=search&h=HEAD&s=a+%3D+b
> 
> which means href() should generate something similar when it
> wants to reproduce what the user queried, doesn't it?  I do not
> think quoting after joining does, and that is why I asked that
> question.

Yes, ot should... but first we would have to convert all the cases of generating URI via esc_param(...) to using href(). That means to extend href() somewhat (-absolute=>1 as special value in href() parameters, or changing href(%) to href(\%;$)?) to be able to generate absolute URI (for example for RSS/OPML).

And the case is not that inconceivable: $project can be anything, and can have ';' and '=' inside. I'm not sure about valid symbolic refs...

Usage of '&' as query parameters separator instead of ';' probably depend on the browser...

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
Previous: Junio C HamanoNext: Randal L. Schwartz
Message 11 of 17 in “[RFD] gitweb: href() function to generate URLs for CGI”
  1. Jakub NarebskiAug 21, 2006
  2. Jakub NarebskiAug 21, 2006
  3. Junio C HamanoAug 21, 2006
  4. Jakub NarebskiAug 21, 2006
  5. Junio C HamanoAug 22, 2006
  6. Jakub NarebskiAug 22, 2006
  7. Junio C HamanoAug 22, 2006
  8. Jakub NarebskiAug 22, 2006
  9. Jakub NarebskiAug 22, 2006
  10. Junio C HamanoAug 22, 2006
  11. Jakub NarebskiAug 22, 2006
  12. Randal L. SchwartzAug 22, 2006
  13. Jakub NarebskiAug 22, 2006
  14. Jakub NarebskiAug 22, 2006
  15. Junio C HamanoAug 22, 2006
  16. 1/2 gitweb: Drop the href() params which keys are not in %mappingJakub Narebski, Aug 22, 2006
  17. 2/2 gitweb: Sort CGI parameters returned by href()Jakub Narebski, Aug 22, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.