Re: [PATCH] revert: initialize const value

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Aug 4, 2025, 13:51 UTC
Message-ID: <ebcc5e06-6d0f-43f0-951a-226558702a9e@gmail.com>
In-Reply-To: <aJC3OiJoqJRnR_My@pks.im>

On 04/08/2025 14:35, Patrick Steinhardt wrote:

Show 10 quoted lines

> On Mon, Aug 04, 2025 at 09:01:41AM -0400, Jeff King wrote:
>> 
>> Hmm, I guess one other option I did not consider: we could just drop the
>> "const". The pointers to it are "const char *", but it is fine for them
>> to point to a non-const variable. Maybe that is less mysterious.
> 
> Initializing the value feels like a pragmatic choice to me. There is no
> downside, and anyone who might be puzzled by the comment is likely to
> git-blame(1) to your commit anyway. So I think the current version is
> good enough.

Yes the current version looks reasonable to me

Thanks

Phillip